Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc version dropdown renders too long on tall screens #3879

Open
mbroz2 opened this issue Oct 18, 2024 · 4 comments
Open

Doc version dropdown renders too long on tall screens #3879

mbroz2 opened this issue Oct 18, 2024 · 4 comments
Assignees
Labels
bug Problems found in prod branch good first issue

Comments

@mbroz2
Copy link
Member

mbroz2 commented Oct 18, 2024

On taller screens, the doc version dropdown doesn't vertically wrap properly, rendering longer than necessary, leaving a bunch of white space at the bottom (tested on chrome and safari). This doesn't happen on short displays.

image

@mbroz2 mbroz2 added bug Problems found in prod branch good first issue labels Oct 18, 2024
@SteveSamJacob19 SteveSamJacob19 self-assigned this Oct 22, 2024
@SteveSamJacob19
Copy link
Contributor

Hi @mbroz2 , can you elaborate on what you mean by taller screens, like what size because i'm not able to recreate this with my desktop full window.

@mbroz2
Copy link
Member Author

mbroz2 commented Oct 22, 2024

Here's an example with a height of 1275 pixels:
image

But anything over a height of 860 pixels (given our current 16 versions) starts to add the white space to the bottom of the drop down (fyi, I see the same behavior on mac and windows on chrome, as well as on safari on mac)

@mbroz2
Copy link
Member Author

mbroz2 commented Oct 22, 2024

This height: 75% might be to blame. I would suggest trying max-height: 75% instead

@SteveSamJacob19
Copy link
Contributor

Alright thanks, will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problems found in prod branch good first issue
Projects
Status: New (Untriaged)
Development

No branches or pull requests

2 participants