Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Don't set -e for compound tests managed by test_run #2195

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evgenyz
Copy link
Contributor

@evgenyz evgenyz commented Jan 11, 2025

The test_run wrapper should handle all return codes, we don't want to bail out early.

Fixes: #2110

The test_run wrapper should handle all return codes, we don't
want to bail out early.
@evgenyz evgenyz requested a review from jan-cerny January 11, 2025 10:56
@evgenyz
Copy link
Contributor Author

evgenyz commented Jan 11, 2025

@jan-cerny In this draft I've only changed a handful of compound tests, but we probably should do that to all of them. What do you think?

@evgenyz evgenyz added this to the 1.4.2 milestone Jan 11, 2025
@jan-cerny
Copy link
Member

IIUC most of the test functions don't return any return value, they rely on that the set -e will cause that once any command in the function returns non-zero value the test will exit and fail. This is the case for all the grep, assert_exists and similar calls. So if you remove set -e the test will start passing permanently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skipping a test, skips all subsequent tests in file
2 participants