Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO23150 compliance: Adding new states to [StationaryObject – Classification - Type] #641

Open
FlorianMueller87 opened this issue Jun 9, 2022 · 2 comments · May be fixed by #661
Open
Assignees
Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards.

Comments

@FlorianMueller87
Copy link
Contributor

FlorianMueller87 commented Jun 9, 2022

Describe the feature

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_objects – StationaryObject – Classification - Type to be compatible with AUTOSAR ADI GeneralLandmarkClassificationType.

Describe the solution you would like

Add in osi_objects – StationaryObject – Classification - Type the following entries:

//
//
TYPE_ BARREL = 17;

//
//
TYPE_ GUIDE_POST = 18;

//
//
TYPE_ TUNNEL = 19;

Describe alternatives you have considered

No alternative was considered.

Describe the backwards compatibility

The adding of the elements will not lead to backward compatibility issues.

Additional context

ISO23150:2021 A.2.105 General landmark classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Jun 15, 2022
@jdsika jdsika self-assigned this Jun 15, 2022
@pmai
Copy link
Contributor

pmai commented Jul 8, 2022

I'm a bit confused why TYPE_VERTICAL_STRUCTURE and TYPE_RECTANGULAR_STRUCTURE occur in this list, since they are verbatim already part of OSI's definition.

Similarly TYPE_LAMP_POST, TYPE_OVERHEAD_OBJECT, TYPE_REFLECTOR, and TYPE_BEACON are already present as TYPE_POLE, TYPE_OVERHEAD_STRUCTURE, TYPE_REFLECTIVE_STRUCTURE, and TYPE_CONSTRUCTION_SITE_ELEMENT.

TYPE_TUNNEL and TYPE_GUIDE_POST might be additions, though I seem to remember discussions to handle them differently...

TYPE_BARREL seems a fairly clear addition.

@FlorianMueller87
Copy link
Contributor Author

Thats correct, I will change this.

FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 9, 2022
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 9, 2022
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
New elements: BARREL, GUIDE_POST, TUNNEL

Issue: OpenSimulationInterface#641
Signed-off-by: FlorianMueller87 <[email protected]>
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
New elements: BARREL, GUIDE_POST, TUNNEL

Issue: OpenSimulationInterface#641
Signed-off-by: FlorianMueller87 <[email protected]>
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
New elements: BARREL, GUIDE_POST, TUNNEL

Issue: OpenSimulationInterface#641
Signed-off-by: FlorianMueller87 <[email protected]>
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
New elements: BARREL, GUIDE_POST, TUNNEL

Issue: OpenSimulationInterface#641
Signed-off-by: FlorianMueller87 <[email protected]>
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
3 participants