-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the orgaadmin to do more #2744
base: main
Are you sure you want to change the base?
Allow the orgaadmin to do more #2744
Conversation
Also allow cloning and deleting of locked meetings as long as the caller has settings manage perms in that meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added some suggestions of which some repeat in other places of the code.
92af550
to
b639322
Compare
I'll preface this by saying: If you want backend development to run efficiently please provide payloads if something's not working. Otherwise the bugs may be hard to replicate. Also: From the fact that I couldn't even replicate the easy-to-understand ones, I wonder if maybe you tested with the wrong backend version.
Couldn't replicate.
There's some fields that shouldn't be working, like the jitsi fields, however I can't tell if they're the ones causing problems for you. Please tell me what fields are causing problems specifically (maybe using the action documentation for meeting.update as a guideline) and please provide a payload anyway.
Couldn't replicate, neither with user.create nor user.update.
As far as I know the client adds the new user separately. Since there are two actions involved, I can't even tell if this is actually a backend problem, or if the client is doing something wrong.
I don't fully grasp what situation you are talking about, since projection dont' have points of order. Also the snackbar message is clearly a client-side error. While this may just be a chain reaction thing caused by a backend error, I really can't tell what the error would actually be, so please provide more information |
The first one is an already existing issue Committe menu > meeting edit: Edit is not possible
Meeting > Participants > Add a user
Meeting > Participant > edit a user:
Motions > create a motion: Didn't work if the submitter is a new participant.:
Meeting > Autopilot: If something is projected, that provides the possibility to create a point of order, this action doesn't work. An error appears, because the orgaadmin is not part of the meeting |
05828fb
to
495b5a9
Compare
What does "new participant" mean? Does that mean that you create a user before? Can you add a payload for that then? |
The new participant is working. Please ignore that part. The orgaadmin should be able to add themselves (only if they do not send submitter_ids) as submitter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm.
Closes #2737
Also allow cloning and deleting of locked meetings as long as the caller has settings manage perms in that meeting