<%= t("decidim.account.email_change.title") %>
+<%= t("decidim.account.email_change.body1", unconfirmed_email: current_user.unconfirmed_email) %>
++ <%== t( + "decidim.account.email_change.body2", + resend_link: link_to(t("decidim.account.email_change.send_again"), resend_confirmation_instructions_account_path, role: :button, method: :post, remote: true), + cancel_link: link_to(t("decidim.account.email_change.cancel"), cancel_email_change_account_path, role: :button, method: :post, remote: true)) %> +
+<%= t(".available_locales_helper") %>
+ + <% if @account.errors[:password].any? || @account.errors[:password_confirmation].any? %> + <%= render partial: "password_fields", locals: { form: f } %> + <% else %> + <% if current_organization.sign_in_enabled? %> ++ +
+", "
") do + Decidim::Faker::Localized.localized { "a" * 1_000_000 } + end + end + let!(:users) { create_list(:user, 100, organization: questionable.organization) } + + before do + users.each do |user| + questions.each do |question| + create(:answer, questionnaire: questionnaire, question: question, user: user) + end + end + end + + it "does not load the questionnaire description to memory every time when iterating an answer" do + # NOTE: + # For this test it is important to fetch the single user "answer + # sets" to an array and store them there because this is the same + # way the answers are loaded e.g. in the survey component export + # functionality. The export had previously a memory leak because the + # questionnaire is fetched individually for each "answer set" and if + # it has a very long description, it caused the description to be + # stored multiple times within the array (for each "answer set" + # separately) causing a out of memory errors when there is a large + # amount of answers. + all_answers = Decidim::Forms::QuestionnaireUserAnswers.for(questionnaire) + + initial_memory = memory_usage + all_answers.each do |answer_set| + described_class.new(answer_set).serialize + end + expect(memory_usage - initial_memory).to be < 10_000 + end + + def memory_usage + `ps -o rss #{Process.pid}`.lines.last.to_i + end + end + end + end + end +end diff --git a/spec/services/decidim/proposals/proposal_serializer_spec.rb b/spec/services/decidim/proposals/proposal_serializer_spec.rb new file mode 100644 index 00000000..37be70a2 --- /dev/null +++ b/spec/services/decidim/proposals/proposal_serializer_spec.rb @@ -0,0 +1,203 @@ +# frozen_string_literal: true + +require "spec_helper" + +module Decidim + module Proposals + describe ProposalSerializer do + subject do + described_class.new(proposal) + end + + let!(:organization) do + create(:organization, available_authorizations: ["phone_authorization_handler"]) + end + + let!(:proposal) { create(:proposal, :accepted) } + let!(:category) { create(:category, participatory_space: component.participatory_space) } + let!(:scope) { create(:scope, organization: component.participatory_space.organization) } + let(:participatory_process) { component.participatory_space } + let(:component) { proposal.component } + + let!(:meetings_component) { create(:component, manifest_name: "meetings", participatory_space: participatory_process) } + let(:meetings) { create_list(:meeting, 2, component: meetings_component) } + + let!(:proposals_component) { create(:component, manifest_name: "proposals", participatory_space: participatory_process) } + + let!(:authorization) do + create( + :authorization, + id: 1, + name: "phone_authorization_handler", + user: proposal.creator_author, + metadata: { + phone_number: "0644444444" + } + ) + end + + let(:other_proposals) { create_list(:proposal, 2, component: proposals_component) } + let(:expected_answer) do + answer = proposal.answer + Decidim.available_locales.each_with_object({}) do |locale, result| + result[locale.to_s] = if answer.is_a?(Hash) + answer[locale.to_s] || "" + else + "" + end + end + end + + before do + proposal.update!(category: category) + proposal.update!(scope: scope) + proposal.link_resources(meetings, "proposals_from_meeting") + proposal.link_resources(other_proposals, "copied_from_component") + end + + describe "#serialize" do + let(:serialized) { subject.serialize } + + it "serializes the id" do + expect(serialized).to include(id: proposal.id) + end + + it "serializes the category" do + expect(serialized[:category]).to include(id: category.id) + expect(serialized[:category]).to include(name: category.name) + end + + it "serializes the scope" do + expect(serialized[:scope]).to include(id: scope.id) + expect(serialized[:scope]).to include(name: scope.name) + end + + it "serializes the title" do + expect(serialized).to include(title: proposal.title) + end + + it "serializes the body" do + expect(serialized).to include(body: proposal.body) + end + + it "serializes the amount of supports" do + expect(serialized).to include(supports: proposal.proposal_votes_count) + end + + it "serializes the amount of comments" do + expect(serialized).to include(comments: proposal.comments.count) + end + + it "serializes the date of creation" do + expect(serialized).to include(published_at: proposal.published_at) + end + + it "serializes the url" do + expect(serialized[:url]).to include("http", proposal.id.to_s) + end + + it "serializes the component" do + expect(serialized[:component]).to include(id: proposal.component.id) + end + + it "serializes the meetings" do + expect(serialized[:meeting_urls].length).to eq(2) + expect(serialized[:meeting_urls].first).to match(%r{http.*/meetings}) + end + + it "serializes the participatory space" do + expect(serialized[:participatory_space]).to include(id: participatory_process.id) + expect(serialized[:participatory_space][:url]).to include("http", participatory_process.slug) + end + + it "serializes the state" do + expect(serialized).to include(state: proposal.state) + end + + it "serializes the reference" do + expect(serialized).to include(reference: proposal.reference) + end + + it "serializes the answer" do + expect(serialized).to include(answer: expected_answer) + end + + it "serializes the amount of attachments" do + expect(serialized).to include(attachments: proposal.attachments.count) + end + + it "serializes the endorsements" do + expect(serialized[:endorsements]).to include(total_count: proposal.endorsements.count) + expect(serialized[:endorsements]).to include(user_endorsements: proposal.endorsements.for_listing.map { |identity| identity.normalized_author&.name }) + end + + it "serializes related proposals" do + expect(serialized[:related_proposals].length).to eq(2) + expect(serialized[:related_proposals].first).to match(%r{http.*/proposals}) + end + + it "doesn't serialize author's data" do + expect(serialized).not_to include(:author) + end + + context "when admin exports proposal" do + subject do + described_class.new(proposal, false) + end + + let(:serialized) { subject.serialize } + + it "serializes author" do + expect(serialized).to include(:author) + end + + it "data in author are not empty" do + expect(serialized[:author][:name]).not_to be_empty + expect(serialized[:author][:nickname]).not_to be_empty + expect(serialized[:author][:email]).not_to be_empty + expect(serialized[:author][:phone_number]).not_to be_empty + end + + context "when proposal was created by admin from backoffice" do + let!(:admin) { create(:user, :admin) } + + before do + proposal.coauthorships.clear + proposal.add_coauthor(proposal.organization) + end + + it "serializes author" do + expect(serialized).to include(:author) + end + + it "author's data are empty" do + expect(serialized[:author][:name]).to be_empty + expect(serialized[:author][:nickname]).to be_empty + expect(serialized[:author][:email]).to be_empty + expect(serialized[:author][:phone_number]).to be_empty + end + end + + context "when there is no authorization for user" do + let(:authorization) { nil } + + it "author's phone number should be empty" do + expect(serialized[:author][:name]).not_to be_empty + expect(serialized[:author][:nickname]).not_to be_empty + expect(serialized[:author][:email]).not_to be_empty + expect(serialized[:author][:phone_number]).to be_empty + end + end + end + + context "with proposal having an answer" do + let!(:proposal) { create(:proposal, :with_answer) } + + it "serializes the answer" do + expect(serialized).to include(answer: expected_answer) + end + end + end + end + end +end diff --git a/spec/wicked_pdf_spec.rb b/spec/wicked_pdf_spec.rb new file mode 100644 index 00000000..34049408 --- /dev/null +++ b/spec/wicked_pdf_spec.rb @@ -0,0 +1,9 @@ +# frozen_string_literal: true + +require "spec_helper" + +describe "WickedPdf" do + it "has version 2.6.3" do + expect(WickedPdf::VERSION).to eq("2.6.3") + end +end From bd14241daeb046843c1637343f9356badec56978 Mon Sep 17 00:00:00 2001 From: Guillaume MORET <90462045+AyakorK@users.noreply.github.com> Date: Wed, 3 Apr 2024 15:17:12 +0200 Subject: [PATCH 04/28] fix: Abnormal mandatory attachment in Collaborative Drafts (#512) * fix: Remove useless override * fix: Remove locales related to the other file --- .../_edit_form_fields.html.erb | 83 ------------------- config/locales/en.yml | 3 - config/locales/fr.yml | 3 - 3 files changed, 89 deletions(-) delete mode 100644 app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb diff --git a/app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb b/app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb deleted file mode 100644 index 527a862f..00000000 --- a/app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb +++ /dev/null @@ -1,83 +0,0 @@ -<%= form_required_explanation %> - - - - - -<% if @form.component_automatic_hashtags.any? %> -<%= t(".available_locales_helper") %>
@@ -67,4 +66,4 @@ <%= f.submit t(".update_account") %> <% end %> - \ No newline at end of file + diff --git a/config/locales/en.yml b/config/locales/en.yml index 6623ca86..9d681efe 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -38,6 +38,8 @@ en: osp_authorization_workflow: name: Authorization procedure budgets: + order_reminder: + text_message: Your vote is still pending for the participatory budget. Please reconnect to %{organization_host} to confirm it projects: count: projects_count: diff --git a/config/locales/fr.yml b/config/locales/fr.yml index c18db78a..1a4e14cb 100644 --- a/config/locales/fr.yml +++ b/config/locales/fr.yml @@ -40,6 +40,8 @@ fr: osp_authorization_workflow: name: Procédure d'autorisation budgets: + order_reminder: + text_message: Votre vote au budget participatif n'est pas terminé. Pour le terminer, reconnectez-vous sur %{organization_host} projects: count: projects_count: diff --git a/config/secrets.yml b/config/secrets.yml index 66c79445..525f2d0b 100644 --- a/config/secrets.yml +++ b/config/secrets.yml @@ -44,6 +44,7 @@ default: &default sms_gateway: service: <%= ENV.fetch("SMS_GATEWAY_SERVICE", "Decidim::Verifications::Sms::ExampleGateway") %> url: <%= ENV["SMS_GATEWAY_URL"] %> + bulk_url: <%= ENV["SMS_GATEWAY_BULK_URL"] %> username: <%= ENV["SMS_GATEWAY_USERNAME"] %> password: <%= ENV["SMS_GATEWAY_PASSWORD"] %> platform: <%= ENV["SMS_GATEWAY_PLATFORM"] %> diff --git a/lib/tasks/decidim_app.rake b/lib/tasks/decidim_app.rake index 910e012d..daba7839 100644 --- a/lib/tasks/decidim_app.rake +++ b/lib/tasks/decidim_app.rake @@ -1,5 +1,6 @@ # frozen_string_literal: true +require "net/http/post/multipart" require "decidim_app/k8s/configuration_exporter" require "decidim_app/k8s/organization_exporter" require "decidim_app/k8s/manager" @@ -76,4 +77,71 @@ namespace :decidim_app do DecidimApp::K8s::Manager.run(ENV.fetch("path", nil)) end end + + namespace :budgets do + # This task is used to send a reminder by sms to voters who haven't finished their + # vote for a budget. When you launch the task, you have to pass the id of the budget + # in a variable in terminal + desc "send a reminder to vote for budget" + task send_sms_reminder: :environment do + if (budget_id = ENV.fetch("BUDGET_ID")).nil? + p "You need to provide a budget ID" + next + end + + if (budget = Decidim::Budgets::Budget.find_by(id: budget_id)).nil? + p "Budget with id #{budget_id} not found" + next + end + + organization = budget.organization + + users_ids = Decidim::Budgets::Order.where(budget: budget) + .pending + &.pluck(:decidim_user_id) + if users_ids.empty? + p "no pending votes" + next + end + users = Decidim::User.where(id: users_ids).where.not(phone_number: nil, phone_country: nil) + + if users.blank? + p "no pending votes from users with phone number" + next + end + + filename = "send_sms_reminder_#{Time.current.year}_#{Time.current.month}_#{Time.current.day}_#{Time.current.min}.csv" + message = I18n.t("decidim.budgets.order_reminder.text_message", locale: organization.default_locale, organization_host: organization.host) + + file = Tempfile.new(filename) + CSV.open(file, "w", col_sep: ";") do |csv| + users.each do |user| + csv << ["#{user.phone_country}#{user.phone_number}", message] + end + end + file.rewind + + p "users ids: #{users.ids}" + p "csv done at #{filename}" + + api_url = Rails.application.secrets.dig(:decidim, :sms_gateway, :bulk_url) + username = Rails.application.secrets.dig(:decidim, :sms_gateway, :username) + password = Rails.application.secrets.dig(:decidim, :sms_gateway, :password) + + url = URI(api_url) + request = Net::HTTP::Post::Multipart.new(url, { + u: username, + p: password, + f: "sms", + c: "Reminder", + file: UploadIO.new(file, "text/csv", filename) + }) + + response = Net::HTTP.start(url.hostname, url.port, use_ssl: true) do |https| # pay attention to use_ssl if you need it + https.request(request) + end + + p "API response is #{response.body}" + end + end end