Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighted map pin doesn't reset when returning to search results #103

Closed
reefdog opened this issue Sep 18, 2024 · 0 comments · Fixed by #111
Closed

Highlighted map pin doesn't reset when returning to search results #103

reefdog opened this issue Sep 18, 2024 · 0 comments · Fixed by #111

Comments

@reefdog
Copy link
Collaborator

reefdog commented Sep 18, 2024

We now highlight (and zoom to!) the relevant map pin on a resource detail page (🎉).

However, when returning to the search page, the highlighted pin remains highlighted — although the zoom level does return to default.

We should clear the highlight as well.
reefdog added a commit that referenced this issue Sep 24, 2024
@reefdog
Always reset map pins when changing routes
6701cb6 
Prior to this commit, we only reset all pins styling when changing
between artwork detail pages. This meant going back to the index page
didn’t reset them, leaving the last highlighted pin highlighted.

Now, we reset them whenever the route changes, which is what we intend.

Issue #103 Highlighted map pin doesn't reset when returning to search
           results
@reefdog reefdog mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove map highlight when leaving artwork page OpenTechStrategies/arches-app-exp
1 participant
@reefdog