Remove map highlight when leaving artwork page #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we only reset all pins styling when changing between artwork detail pages. This meant going back to the index page didn’t reset them, leaving the last highlighted pin highlighted. Now, we reset them whenever the route changes, which is what we intend. Issue #103 Highlighted map pin doesn't reset when returning to search results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if you went to an artwork page (which highlights its map pin) and then went back to the search results page (which should clear the highlight), the pin remained highlighted. This PR fixes that.
Testing:
main, navigate to an artwork pageCloses #103