Remove auto-scrolling behavior #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because of the requirement that we check in build assets, and how that means hell for merge conflicts with simultaneous PRs, I'm going to put this into draft status until #90 is merged. |
reefdog
force-pushed
the
92-remove-scrolling
branch
from
b362dba to
1e08e1e
Compare
|
@reefdog I suppose this is a bit wonky. Happy to ditch it in lieu of hiding welcome text. One minor code change request then should be g2g! |
Ack, I'm not seeing any inline code change requests — did it not get sent? |
hminsky2002
requested changes
Sep 17, 2024
Airplane wifi :/ Should be there now! |
This doesn’t work reliably, and even when it does, feels stranger than I expected it would. It will also be less necessary once we hide aren’t showing the welcome text on every page. Issue #92: Remove auto-scrolling behavior when loading detail page
reefdog
force-pushed
the
92-remove-scrolling
branch
from
1e08e1e to
7d132bd
Compare
hminsky2002
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn’t work reliably, and even when it does, feels stranger than I expected it would. It will also be less necessary once we aren’t showing the welcome text on every page.
Resolves #92