From 982e6420397b22c7cebcca293b4467febec6e72f Mon Sep 17 00:00:00 2001 From: Martii Date: Sun, 9 Nov 2014 13:44:06 -0700 Subject: [PATCH] Remove a deprecation warning * Express 3 deprecated this a while back to a separate package. It is currently default used with POST request response so this probably needs to be kept in. Basically they are forcing this `Vary` header in on all form request responses...e.g. defining a newer type of standard. `'X-HTTP-Method-Override'` is placed in regardless of `methodOverride` parm being used or not. Pkg docs say to use it in intial setup. Tested on route `'/script/:namespace?/:scriptname/edit'` See also: * https://github.com/OpenUserJs/OpenUserJS.org/issues/315#issuecomment-59668729 and forward --- app.js | 3 ++- package.json | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app.js b/app.js index 5c3466c53..b25076162 100755 --- a/app.js +++ b/app.js @@ -1,6 +1,7 @@ 'use strict'; var express = require('express'); +var methodOverride = require('method-override'); var minify = require('express-minify'); var MongoStore = require('connect-mongo')(express); var mongoose = require('mongoose'); @@ -50,7 +51,7 @@ if (process.env.NODE_ENV !== 'production') { app.use(express.urlencoded()); app.use(express.json()); app.use(express.compress()); -app.use(express.methodOverride()); +app.use(methodOverride('X-HTTP-Method-Override')); // Order is very important here (i.e mess with at your own risk) app.use(express.cookieParser()); diff --git a/package.json b/package.json index d9fdf14d0..535a598f7 100644 --- a/package.json +++ b/package.json @@ -18,6 +18,7 @@ "highlight.js": "8.3.0", "jquery": "2.1.1", "marked": "0.3.2", + "method-override": "2.3.0", "moment": "2.8.3", "mongoose": "3.8.19", "mu2": "0.5.20",