Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update userscript #2045

Closed
qsniyg opened this issue Dec 24, 2024 · 3 comments
Closed

Can't update userscript #2045

qsniyg opened this issue Dec 24, 2024 · 3 comments
Labels
duplicate This means already been reported. Always reference in a comment what issue or pull request number… intended behavior "It's a feature not a bug."

Comments

@qsniyg
Copy link

qsniyg commented Dec 24, 2024

What happened?

Normally my userscript (https://openuserjs.org/scripts/qsniyg/Image_Max_URL) auto-updates when the source (https://github.com/qsniyg/maxurl/blob/master/build/userscript_extr_min.user.js) updates, but it failed to update this time for some reason.

I tried manually updating it, but it sent the error "Payload is too large". It's ~652KB, which is under the 1MB limit.

What did you expect to happen?

It should have been auto-updated.

What the problem might be?

No response

@qsniyg qsniyg added the bug You've guessed it... this means a bug is reported. label Dec 24, 2024
@Martii
Copy link
Member

Martii commented Dec 24, 2024

Your installation URL is https://openuserjs.org/install/qsniyg/Image_Max_URL.user.js which means your phantom usersript_extr_min.user.js won't be doing much unless it has a created homepage on OUJS.... which it does not at the time of this writing. I only see one script on your account and that is the only one that is possibly syncable at this time if the size is within the limits. i.e. this is inteneded behavior.

I tried manually updating it, but it sent the error "Payload is too large". It's ~652KB, which is under the 1MB limit.

This part is a known issue at #793 and is a duplicate. Best to utilize properly the webhook instead at this time.

@Martii Martii added duplicate This means already been reported. Always reference in a comment what issue or pull request number… intended behavior "It's a feature not a bug." and removed bug You've guessed it... this means a bug is reported. labels Dec 24, 2024
@qsniyg
Copy link
Author

qsniyg commented Dec 24, 2024

Thanks for your response, I fixed it by creating a dummy commit only changing extr_min: qsniyg/maxurl@4212e1f

For some reason it said "OK" for the previous extr_min script, but then failed to sync regardless. Maybe this is because userscript.user.js was changed in the same commit, and it tried to sync that one afterwards?
maxurlsync

@Martii
Copy link
Member

Martii commented Dec 26, 2024

For some reason it said "OK" for the previous extr_min script, but then failed to sync regardless

That was confirmed by me when you opened the issue... however... I did match a portion of your repo files and it synced both (because they are both within limits). All I can think of is that this time of year the bad actors like to get out more and attempt to drag the site down. There is also the possibility that GH rate limited us. They like to do that more now.

Maybe this is because userscript.user.js was changed in the same commit, and it tried to sync that one afterwards?

Because you are reusing the @name for all of them there is no guarantee on the order of processing and timely processing. This is described under the caveats section. As far as it not syncing there have been multiple reconnects with the MongoDB so perhaps you hit a spot where it wasn't connected. Unfortunately all failure paths still aren't fully trapped and that dependency could be to blame as well including the binary.

Because I can't reproduce it I'll have to leave the labels as is but I'll keep my eyes out for anything out of the unusual.

@Martii Martii closed this as completed Dec 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This means already been reported. Always reference in a comment what issue or pull request number… intended behavior "It's a feature not a bug."
Development

No branches or pull requests

2 participants