Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post fix for incorrect type #1827

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Post fix for incorrect type #1827

merged 1 commit into from
Jul 21, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 21, 2021 •
edited
Loading

  • We already have the hex and default for Buffer is utf... so coerce it to hex
  • Open up script sending to this methodology. Minification output support may come later but if one relies on the hash and something changes in the backend it can easily foo script installation. Will have to ponder some more.

Post #1826

Integrity test:

sha512sum -b FILENAME.js | awk '{ print $1 }' | xxd -r -p | base64

@Martii
Post fix for incorrect type
93aaf4d 
* We already have the hex and default for Buffer is `utf`... so coerce it to `hex`
* Open up script sending to this methodology. Minification output support may come later but if one relies on the hash and something changes in the backend it can easily foo script installation. Will have to ponder some more.

Post OpenUserJS#1826
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 21, 2021
@Martii Martii merged commit 715c10b into OpenUserJS:master Jul 21, 2021
@Martii Martii deleted the pull-1826postfix branch July 21, 2021 11:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii