Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20 Approval event conformance #1955

Closed
k06a opened this issue Oct 18, 2019 · 2 comments
Closed

ERC20 Approval event conformance #1955

k06a opened this issue Oct 18, 2019 · 2 comments

Comments

@k06a
Copy link
Contributor

k06a commented Oct 18, 2019

ERC20 Token Standard tells:

Approval
MUST trigger on any successful call to approve(address _spender, uint256 _value).

But current ERC20 implementation emits Approval event on every allowance change. Is there any practical reason for this or just a bug?

Original discussion started here: makerdao/dss#76

@nventuro
Copy link
Contributor

This has been discussed extensively in the past, and was a concious design decision. You can read more about the motivation on this issue (and associated PR): #707. The short version is that not emitting those events makes it impossible to reconstruct the state from events only.

Is this causing any issues in your application?

@k06a
Copy link
Contributor Author

k06a commented Oct 18, 2019

@nventuro that makes sense 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants