Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-Invite to Military or Veteran Related Channels on Join #110

Open
brownnrl opened this issue Sep 27, 2019 · 3 comments
Open

Auto-Invite to Military or Veteran Related Channels on Join #110

brownnrl opened this issue Sep 27, 2019 · 3 comments
Labels
feedback: discussion Active discussion is happening to scope this issue, set acceptance criteria, or decide to accept it priority: medium This is an issue that has some urgency but isn't an emergency status: awaiting acceptance Issue has not been accepted - it may need documentation, discussion, or a decision - the ice box type: code change Issue requires changes to the code base type: documentation Issue requires a change to the current documentation of the codebase or product type: enhancement Issue enhances a feature by adding more functionality type: feature Issue involves adding new functionality that doesn't currently exist

Comments

@brownnrl
Copy link

Cross link between back end issue 47.

The back end optionally passes the military status info to pybot, pybot has an association of military status to channel ID, and submits that with the optional parameters of the undocumented slack api call users.admin.invite called here with those slack channel ids if present.

Additional information is presented in this SO post.

A warning should be noted that this feature may be deprecated in favor of the priced (Plus/Enterprise) slack APIs in the future.
@kylemh kylemh added the general: hacktoberfest Issue is a good fit for Hacktoberfest label Oct 1, 2019
brownnrl added a commit to brownnrl/operationcode-pybot that referenced this issue Oct 2, 2019
@brownnrl
(OperationCode#110) Adds an update method to communicate military status
1992112 
When an update is recv'd from the backend about military status, this
will send a message about what channel to join (which can be swapped
or enhanced with a call to channels.invite).
@brownnrl brownnrl mentioned this issue Oct 2, 2019
Open
@AllenAnthes AllenAnthes removed the general: hacktoberfest Issue is a good fit for Hacktoberfest label Dec 29, 2019
@kylemh kylemh added the general: hacktoberfest Issue is a good fit for Hacktoberfest label Oct 1, 2020
@aaron-junot aaron-junot added priority: high This is an issue that should be fixed first and removed general: hacktoberfest Issue is a good fit for Hacktoberfest labels Aug 18, 2021
@JudsonStevens
Copy link
Collaborator

@kylemh @hollomancer - I'm missing some context here; Aaron and I think there has been some discussion around putting this into the initial form users fill out to even get the first invitation. Is that a viable route or do we still want to prioritize this and the related backend issue?

@aaron-junot aaron-junot mentioned this issue Aug 18, 2021
Closed
@kylemh
Copy link
Member

kylemh commented Aug 19, 2021

Out of the loop as well. We collect that info during reg but don't verify

@aaron-junot aaron-junot added priority: medium This is an issue that has some urgency but isn't an emergency and removed priority: high This is an issue that should be fixed first labels Dec 15, 2021
@JudsonStevens
Copy link
Collaborator

Alright - if we have that information then I think we can work this one similar to the zip code one - we pull that information from the backend and for current users send them a DM with the relevant channels for their branch of service. For new users we auto-invite them to the relevant channels as well. The admin namespace for the Slack Web API has been moved to Enterprise only so we can use the conversations.invite API call.

@JudsonStevens JudsonStevens added feedback: discussion Active discussion is happening to scope this issue, set acceptance criteria, or decide to accept it status: awaiting acceptance Issue has not been accepted - it may need documentation, discussion, or a decision - the ice box type: code change Issue requires changes to the code base type: documentation Issue requires a change to the current documentation of the codebase or product type: enhancement Issue enhances a feature by adding more functionality type: feature Issue involves adding new functionality that doesn't currently exist labels Jan 2, 2022
@JudsonStevens JudsonStevens changed the title Extend pybot API for user invitations so that military status is conveyed. Invite users to the appropriate veteran or military related channels on join depending on military status Jan 2, 2022
@JudsonStevens JudsonStevens changed the title Invite users to the appropriate veteran or military related channels on join depending on military status Auto-Invite to Military or Veteran Related Channels on Join Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback: discussion Active discussion is happening to scope this issue, set acceptance criteria, or decide to accept it priority: medium This is an issue that has some urgency but isn't an emergency status: awaiting acceptance Issue has not been accepted - it may need documentation, discussion, or a decision - the ice box type: code change Issue requires changes to the code base type: documentation Issue requires a change to the current documentation of the codebase or product type: enhancement Issue enhances a feature by adding more functionality type: feature Issue involves adding new functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brownnrl @aaron-junot @kylemh @AllenAnthes @JudsonStevens