Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmlClass attribute in uiselect #106

Open
mferreira92 opened this issue Mar 20, 2017 · 1 comment
Open

htmlClass attribute in uiselect #106

mferreira92 opened this issue Mar 20, 2017 · 1 comment

Comments

@mferreira92
Copy link

Hi,

htmlClass attribute (e.g. col.xs.3) works as expected when using strapselect, however, when using the uiselect, I noticed that this attribute is not being transmited to the form in angular-schema-form-dynamic-select.js.

I've changed the code to allow this key also on uiselect and works great however I'm not aware if it has any consequences?
In this section:
<div ng-controller=\"dynamicSelectController\" class=\"form-group (...)

I have changed to the following:
<div ng-controller=\"dynamicSelectController\" class=\"form-group {{form.htmlClass}} (...)
If this is not the correct approach, can you please let me know the best method to give htmlclass to a uiselect?

Thank you!

@nicklasb
Copy link
Member

That looks good to me, if you have the opportunity, I'd certainly appreciate a PR with that in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants