Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Create component - Checkbox #264

Open
29 tasks
B3nz01d opened this issue Oct 31, 2024 · 1 comment · May be fixed by #402
Open
29 tasks

[Component] Create component - Checkbox #264

B3nz01d opened this issue Oct 31, 2024 · 1 comment · May be fixed by #402
Assignees
Labels
⚛️ component Related to a component provided by the library 📱 demo app Update of the Demo App 📖 documentation Improvements or additions to documentation 📘 library

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 31, 2024

Description

As a user of thelibrary
I want to be able to use the component checkbox
So that I can add configurable chexboxes in my own projects

As a user of the library
I want to be able to use the component
So that I have access to the documentation on how to use it

As a user of the Design System Toolbox
I want to access the component
So that I can understand how to use it:

  • while using the demo app I can interact with the available options and observe the changes on the component itself
  • I can see the code associated to the component customization
  • I can copy and paste the code from the app based on the selected customization
  • or when looking into the code of the app itself, I would also understand how to use it

Design guidelines

unified-design-system.orange.com

Context

The component is described in the Figma boards and some rules defined in the SharePoint playbook.

Definition of Done

Main topics

  • Implement the chebokx component
  • Update documentation (both DocC catalog and Swift source doc)
  • Add if needed unit tests
  • Add UI tests on component look and feel

Related to implementation

For layouts:

  • default
  • inverse / RTL
  • checkox only

For selection status:

  • selected
  • unselected
  • underterminate
  • error variant

For states:

  • enabled
  • hover
  • pressed
  • loading
  • disabled
  • focus
  • read only
  • skeleton

For options:

  • Icon
  • helper text
  • divider

For a11y:

  • keyboard navigation
  • Voice Over navigation
  • click on label select the box
  • define accessibilty label even of icon only checbkoxes

For tokenator:

  • Use of component tokens

Other details picked from playbook (v0.4):

  • ​All the "list item" can be clicked to check/uncheck the corresponding checkbox
  • You can't mix item with divider and item without in a same list. All divider status must be the same between item of a list.​
@B3nz01d B3nz01d added ⚛️ component Related to a component provided by the library 📖 documentation Improvements or additions to documentation 📘 library 📱 demo app Update of the Demo App labels Oct 31, 2024
@pylapp pylapp moved this from Triage to Todo in [OUDS] Project Jan 20, 2025
@pylapp pylapp self-assigned this Jan 22, 2025
@pylapp pylapp moved this from Todo to In Progress in [OUDS] Project Jan 22, 2025
pylapp added a commit that referenced this issue Jan 22, 2025
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
Copy link
Member

pylapp commented Jan 23, 2025

ℹ️ FYI I updated the issue with some details and requirements about what must be done.

@pylapp pylapp linked a pull request Jan 23, 2025 that will close this issue
16 tasks
@pylapp pylapp linked a pull request Jan 23, 2025 that will close this issue
16 tasks
pylapp added a commit that referenced this issue Jan 23, 2025
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛️ component Related to a component provided by the library 📱 demo app Update of the Demo App 📖 documentation Improvements or additions to documentation 📘 library
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants