-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject the IStore.IConfiguration into the DI to make it modifiable #14959
Comments
I think this needs to be moved into YesSQL repo
Why? |
Just open up some Configuation for developers to change, |
Yes , here sebastienros/yessql#521 And I remember that improvement suggestion you were talking about. Why didn't I find... |
@hyzx86 if you want to change the configurations of YesSQL in your project, you may do so by configuring YesSqlOptions. If you need to access the configuration, you can do so by injection an If you want to suggest improvements to YesSql, you may file and issue and follow it with PR in the YesSQL repository. |
I saw that type, but it constrained me to configure Yessql freely when testing dynamic indexes. Actually going back to the original idea, I just wanted to implement a method like this public class PropertyIndexProvider : IndexProvider<Property>
{
public override void Describe(DescribeContext<ContentItem> context)
{
Type myType= getMyType(contentItem);
context
.For(myType)// make here support dynamic type
.Map(property =>{
var indexObj= getIndexModel(property)
return indexObj;//object
});
}
} The Yessql code is a bit complicated, and I'm trying to figure out the logic |
Use another solution sebastienros/yessql#525 |
Hi @MikeAlhayek ,
Are there any problems if we inject this configuration into DI?
I'm trying to implement dynamic indexing sebastienros/yessql#521
So I need to change the
Store.Configuation
https://github.com/OrchardCMS/OrchardCore/blob/f477647f067ad68701a3ae26e0d41419fa1526db/src/OrchardCore/OrchardCore.Data.YesSql/OrchardCoreBuilderExtensions.cs#L66C33-L66C33
The text was updated successfully, but these errors were encountered: