Use AddPermissionProvider & AddNavigationProvider in OpenID #16960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please do the same thing everywhere so we don't have 1 PR per file? https://github.com/search?q=repo%3AOrchardCMS%2FOrchardCore+ServiceDescriptor.Scoped%3C&type=code |
|
The aim is not to replace the |
|
These are the only not updated in the code base |
|
To make this PR more useful, I suggest to replace all these https://github.com/search?q=repo%3AOrchardCMS%2FOrchardCore+services.TryAddEnumerable&type=code this way we don't see many PR like this doing the same thing just for another service. |
|
Just one thing I'm afraid of is to break existing behavior coz TryAddXXX is not similar to AddXXX |
MikeAlhayek
reviewed
Nov 6, 2024
src/OrchardCore/OrchardCore.Infrastructure/Entities/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
MikeAlhayek
approved these changes
Nov 6, 2024
hishamco
commented
Nov 7, 2024
src/OrchardCore/OrchardCore.Infrastructure/Entities/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
…lectionExtensions.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.