Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Famous Google IP 8.8.8.8 failed to parse #16

Open
sensboston opened this issue Oct 23, 2024 · 12 comments
Open

Famous Google IP 8.8.8.8 failed to parse #16

sensboston opened this issue Oct 23, 2024 · 12 comments

Comments

@sensboston
Copy link

The database is really good and working pretty well, except one small but a strange thing: the well-known, famous Google's IP 8.8.8.8 is failed to parse! Why?

I settled up small php script to use DB, and here is result: https://senssoft.com/geo/geoip.php?ip=8.8.8.8

Any advice?

@dgw
Copy link

dgw commented Oct 23, 2024

Looks fine to me?

{"ip":"8.8.8.8","city":"N\/A","region":"N\/A","country":"United States","latitude":37.751,"longitude":-97.822,"asn":15169,"asn_org":"GOOGLE"}

That is the output from your script.

@sensboston
Copy link
Author

@dgw, "city":"N\/A","region":"N\/A - nothing bothers you?
As an example: https://ipinfo.io/8.8.8.8 looks way better (yes, I know it's commercial site but)

@dgw
Copy link

dgw commented Oct 23, 2024

No, the city and region data being "N/A" doesn't bother me. 8.8.8.8 is an anycast address; it isn't bound to a specific location.

First of all, you need to be more specific with what you think is wrong here. Seems to "parse" just fine; is your issue with the data/result?

And secondly, this repo doesn't originate the data. If you have problems with the data accuracy, take it up with MaxMind.

@sensboston
Copy link
Author

sensboston commented Oct 23, 2024

@dgw, I don't get your point at all, sorry. If you don't care about city and region, it's your private business; but talking about database consistency, it's a bug.

8.8.8.8 is an anycast address

Nope, you're completely wrong. It's a Google's address.

@dgw
Copy link

dgw commented Oct 23, 2024

8.8.8.8 is an anycast address

Nope, you're completely wrong. It's a Google's address.

The site you linked even has it tagged as "anycast". It is an anycast address. Pretty much all the well-known global DNS resolvers (Quad9, Cloudflare 1.1.1.1, Google DNS, OpenDNS, …) use anycast routing so clients always get connected to the closest datacenter.

And again: This repo does not maintain the data. MaxMind chose not to associate a location with Google's anycast IP here, not P3TERX. Go suggest the correction to MaxMind. It'll get pulled in here if they issue an update containing the change.

@sensboston
Copy link
Author

What is your point? "If I don't need city and region that means nobody needs 'em"? Are you maintainer of this DB? No! My question does not apply to you at all.

@dgw
Copy link

dgw commented Oct 23, 2024

I am trying to help you realize that P3TERX (the repo owner) also does not maintain the database itself… What's here is just a convenience, drawing on data from MaxMind.

But all I can do is try to convey accurate information about where you should go to attempt to have the data fixed. I've told you all I can on that front. If you don't believe me, and the repo's license information also doesn't convince you, by all means wait here for a comment with the "Owner" badge. You will not hear from me again in this thread.

@sensboston
Copy link
Author

@dgw, I'm not an idiot or simpleton; of course I do understand , this DB is stolen or ... . I just stated a fact of existing bug/lack of information. The maintainer (or anyone else) can forward (or can not) this to MaxMind. What's all, end of story. I don't think what @P3TERX will do something about this: he is from China and (I think so) give a damn about US copyright laws.
I opened an issue just to state a fact of existing bug, nothing more. I really love this stolen DB! It's pretty useful and easy to use. But - if it has a bug - why do you argue "there is NO bug"?!

@abdullahdevrel
Copy link

I thought I would share an FYI, as I work for IPinfo. We have data that aligns with the majority opinion about good code standards.

When it comes to anycast IP addresses, we clearly label them in our API service. For location information, we have to choose at least one location point. Even though anycast IPs fundamentally cannot be located to a single location by our geolocation process (ping triangulation), we have hints of every possible place the anycast IPs can be located in.

However, sending an array of cities will disrupt the API response standardization. Therefore, we chose the WHOIS record city address or one of the more popular/frequently location backed by our active measurement. The issue with their database is that you will often see they do not have city information in their city database. So, you might as well use a country database at that point. If you do use a country database, then choose us!

We have a free IP to Country database you can use. It is updated daily, provides full accuracy, and, within the context of this repository, is shared with a CC-BY-SA 4.0 license without an EULA. TLDR on the licensing is that we allow commercial distribution legally, which only requires an attribution.

https://ipinfo.io/products/free-ip-database

Let me know if you have any questions. I would be happy to help!

@sensboston
Copy link
Author

@abdullahdevrel, thanks for clarification. BTW, even it's an anycast address, but you/ipinfo produces a correct output for the well known Google DNS server 8.8.8.8 and with big probability it's located in the Mountain View (what is really good).

As for me, I'm not an active user of ip geolocation services at all. It was just a "proof of concept" for one old fashioned guy who still thinks what IP geolocation by using whois is good :)

@abdullahdevrel
Copy link

Thank you @sensboston. I really appreciate the opportunity to talk with you. We do things a bit differently by using active measurements using our 720+ servers strong network. Ping me anytime in our community if you have any questions about IP geolocation and our services.

@jagan318
Copy link

jagan318 commented Dec 2, 2024

I really appreciate the opportunity to talk with you. We do things a bit differently by using active measurements using our 720+ servers strong network. Ping me anytime in our community if you have any questions about IP geolocation and our services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants