Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent rendering of the "For more information" section of the "Full Metadata" page #89

Open
clnsmth opened this issue Mar 24, 2023 · 1 comment
Assignees
Labels
bug Bug low priority Low priority

Comments

@clnsmth
Copy link

clnsmth commented Mar 24, 2023

A data package's "Full Metadata" page includes the "For more information:" section for some packages but not others. For example, see the rendered pages of knb-lter-knz.3.15 and knb-lter-knz.91.5, each of which contains the EML <distribution> elements used to populate this information.

EML of knb-lter-knz.3.15:

<distribution>
  <online>
    <url function="information">http://lter.konza.ksu.edu/content/ana01-weekly-seasonal-and-annual-measurement-precipitation-volume-and-chemistry-collected</url>
  </online>
</distribution>
<distribution id="10.6073/pasta/295644787ee8a1c00edd6f48dde75c4e" scope="system" system="https://pasta.edirepository.org">
  <online>
    <url function="information">https://doi.org/10.6073/pasta/295644787ee8a1c00edd6f48dde75c4e</url>
  </online>
</distribution>

and knb-lter-knz.91.5:

<distribution>
  <online>
    <url function="information">http://lter.konza.ksu.edu/content/vir01-effects-invertebate-and-vertebrate-herbivory-tallgrass-prairie-plant-community</url>
  </online>
</distribution>

This behavioral difference correlates with the presence/absence of the <distribution> element's id attribute. When present, the "For more information:" block is rendered, when absent it is not. The code point driving this behavior appears to be:

<xsl:if test="distribution/@id">

A potential solution might be to remove the test for the id attribute?

@servilla
Copy link
Collaborator

The difference in rendering is correctly analyzed by @clnsmth. The distribution element's lack of an @id attribute precludes its rendering.

The root cause of the difference, however, is another matter: apparently, the initial registration of the DOI for knb-lter-knz.91.5 did not occur synchronously with the update of the data package (as it did with knb-lter-knz.3.15); because the Level-1-EML.xml becomes immutable once published, the EML itself will not have an alternateIdentifier or the dataset-level distribution containing the data package DOI (the DOI was subsequently registered about 2 hours post update).

As noted, the lack of a dataset distribution element containing the DOI (and the corresponding id attribute) prevented the "For more information:" block from rendering. EDI policy must decide if any and all dataset-level distribution elements be displayed in the full metadata rendering or only those with an EDI-registered DOI. Regardless, this conditional

      <!-- the dataset-level distribution tag. for LTER, it should be 
           function=information. the link to the data entity itself 
           will be in the entity's tree.  -->
      <xsl:if test="distribution/@id">
        <tr>
          <td colspan="2">
            <table class="subGroup onehundred_percent">
              <tr>
                <td>
                  <table class="{$tabledefaultStyle}">
                    <th colspan="2">For more information:</th>
                    <xsl:for-each select="distribution">
                      <tr>
                        <td class="{$firstColStyle}"><xsl:text>Visit: </xsl:text></td>
                        <td class="{$secondColStyle}">
                          <a>
                            <xsl:attribute name="class">dataseteml</xsl:attribute>
                            <xsl:attribute name="href"><xsl:value-of select="online/url"/>
                            </xsl:attribute><xsl:value-of select="online/url"/>
                          </a>
                        </td>
                      </tr>
                    </xsl:for-each>
                  </table>
                </td>
              </tr>
            </table>
          </td>
        </tr>
      </xsl:if>

within the eml-2.xsl will require modification.

@servilla servilla self-assigned this Mar 24, 2023
@servilla servilla added the bug Bug label Mar 24, 2023
@servilla servilla added the EDI label Oct 31, 2023
@servilla servilla added the low priority Low priority label Dec 7, 2023
@rogerdahl rogerdahl removed the EDI label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug low priority Low priority
Projects
Status: ToDo
Development

No branches or pull requests

3 participants