Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Streaming api #80

Open
frank-dspeed opened this issue Jun 14, 2019 · 3 comments
Open

PR: Streaming api #80

frank-dspeed opened this issue Jun 14, 2019 · 3 comments

Comments

@frank-dspeed
Copy link

This PR Implaments Streaming API and class API

const cwd = process.cwd()
const dockerCompose = require('docker-compose/class') 
const compose = new dockerCompose({ cwd })
compose.upAll()
compose.upAllStream()
compose.logsStream()

Will Write more soon and Push my Integration for this module

@frank-dspeed
Copy link
Author

frank-dspeed commented Jun 14, 2019

@Steveb-p
Copy link
Contributor

Steveb-p commented Jun 14, 2019

It's not a PR though :)

At this point it doesn't seem to differ too much. Looking forward to it.

Just a note: since we're still "supporting" NodeJS 6 (which didn't have class support afair) we will need to have compilation process ready to downgrade the code. Also, I'm not 100% exactly sold on using a class, but it's more an opinion than anything.

@AlexZeitler
Copy link
Contributor

AlexZeitler commented Jun 14, 2019

@frank-dspeed Thanks for your work.
As @Steveb-p said, it's not a PR - if you need help here, just let us know.

@Steveb-p Node.js 6 did support ES6 class.
As Node 6 is EOL I'm considering to no longer support it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants