Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of Jackson #979

Open
Rubydesic opened this issue Nov 23, 2022 · 1 comment
Open

Update to latest version of Jackson #979

Rubydesic opened this issue Nov 23, 2022 · 1 comment

Comments

@Rubydesic
Copy link

'com.fasterxml.jackson.core:jackson-annotations:2.9.0',
'com.fasterxml.jackson.core:jackson-core:2.9.7',
'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.9.7',
'com.fasterxml.jackson.core:jackson-databind:2.9.7',

OpenTerrainGenerator shades a very old version of Jackson which causes compatibility issues when it's loaded before Valkyrien Skies 2, which requires a newer version. The latest version of Jackson is 2.14.1

FrankTCA added a commit to FrankTCA/OpenTopG that referenced this issue Dec 8, 2022
OTG is currently using an extremely old version of YAML (esp. Jackson), outlined here: PG85/OpenTerrainGenerator#979

Since OTG team has disappeared at the moment, we are changing this here, and maybe they will (or won't) change this themselves.
@StupidCornfield-Auto
Copy link

Will be fixed along w/ Fabric Support for 1.18.2 and 1.19 0.0.30, we will also be continuing support for 1.16 OTG with minor fixes such as this (w/o Fabric for the time being), but will save that for another day.

Changes have been committed to 1.18.2 branch, artifact created OK, untested as of yet (busy), will not commit to 1.19 till after support for 1.19 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants