Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield should quietly resume after stream-sync errors #489

Open
JSKitty opened this issue Dec 10, 2024 · 0 comments
Open

Shield should quietly resume after stream-sync errors #489

JSKitty opened this issue Dec 10, 2024 · 0 comments
Labels
Bug This is either a bugfix (PR) or a bug (issue).

Comments

@JSKitty
Copy link
Member

JSKitty commented Dec 10, 2024

Currently, if the stream errors during Shield Sync, the wallet either seems to restart the sync entirely (due to hitting 'Bad root' logic) or causes the wallet to enter a bad sync state, where it soft-locks.

This only seems to be an issue on extremely weak or slow connections, but it is still a problem that could potentially lock out some users or make their usage of MPW very inconsistent.

Ideally, this should be handled by resuming from the last Shield block synced, quietly, making it unnoticable for users.

@JSKitty JSKitty added the Bug This is either a bugfix (PR) or a bug (issue). label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

No branches or pull requests

1 participant