Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded messages with slot-based customization #2

Open
warpech opened this issue May 28, 2018 · 0 comments
Open

Replace hard-coded messages with slot-based customization #2

warpech opened this issue May 28, 2018 · 0 comments

Comments

@warpech
Copy link

warpech commented May 28, 2018

Moved from Palindrom/palindrom-client#37


@tomalec wrote:

Currently, we have hard-coded texts, and HTML structure for presenting messages at https://github.com/PuppetJs/puppet-polymer-client/blob/gh-pages/puppet-client.html#L72

Due to i18n, a11y, customization, theming, cheeper maintenance, etc. those should be customizable.

In my opinion the best way to do so is to use <slot>, we can provide fallback content inside, but tu CE consumer could simply write his/her own:

<puppet-client>
   <div slot="reconnecting-now" class="my-custom-styles">Łączę ponownie</div>
</puppet-client>

So we will no longer have to bother about how to show the message for the mobile, in different language, in different context, etc.

//cc @warpech @mnosek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant