From c623d12ffde04cc6554169b3a9b34af6d6062df6 Mon Sep 17 00:00:00 2001
From: Krzysztof Klimonda <kklimonda@paloaltonetworks.com>
Date: Tue, 14 Jan 2025 15:57:19 +0100
Subject: [PATCH] Update acceptance tests to better verify entries order on the
server post creation
---
assets/terraform/test/resource_security_policy_test.go | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/assets/terraform/test/resource_security_policy_test.go b/assets/terraform/test/resource_security_policy_test.go
index c943219d..ab007921 100644
--- a/assets/terraform/test/resource_security_policy_test.go
+++ b/assets/terraform/test/resource_security_policy_test.go
@@ -426,8 +426,8 @@ func TestAccSecurityPolicyOrdering(t *testing.T) {
nameSuffix := acctest.RandStringFromCharSet(6, acctest.CharSetAlphaNum)
prefix := fmt.Sprintf("test-acc-%s", nameSuffix)
- rulesInitial := []string{"rule-1", "rule-2", "rule-3"}
- rulesReordered := []string{"rule-2", "rule-1", "rule-3"}
+ rulesInitial := []string{"rule-1", "rule-2", "rule-3", "rule-4", "rule-5"}
+ rulesReordered := []string{"rule-2", "rule-1", "rule-3", "rule-4", "rule-5"}
prefixed := func(name string) string {
return fmt.Sprintf("%s-%s", prefix, name)
@@ -481,6 +481,8 @@ func TestAccSecurityPolicyOrdering(t *testing.T) {
stateExpectedRuleName(0, "rule-1"),
stateExpectedRuleName(1, "rule-2"),
stateExpectedRuleName(2, "rule-3"),
+ stateExpectedRuleName(3, "rule-4"),
+ stateExpectedRuleName(4, "rule-5"),
ExpectServerSecurityRulesCount(prefix, sdkLocation, len(rulesInitial)),
ExpectServerSecurityRulesOrder(prefix, sdkLocation, rulesInitial),
},
@@ -508,12 +510,16 @@ func TestAccSecurityPolicyOrdering(t *testing.T) {
planExpectedRuleName(0, "rule-2"),
planExpectedRuleName(1, "rule-1"),
planExpectedRuleName(2, "rule-3"),
+ planExpectedRuleName(3, "rule-4"),
+ planExpectedRuleName(4, "rule-5"),
},
},
ConfigStateChecks: []statecheck.StateCheck{
stateExpectedRuleName(0, "rule-2"),
stateExpectedRuleName(1, "rule-1"),
stateExpectedRuleName(2, "rule-3"),
+ stateExpectedRuleName(3, "rule-4"),
+ stateExpectedRuleName(4, "rule-5"),
ExpectServerSecurityRulesOrder(prefix, sdkLocation, rulesReordered),
},
},