Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/obj/item/organ/external/rejuvenate() throw an runtime, when you splash mitocholide on dismembered limb #26996

Open
1 task done
msw7007 opened this issue Oct 6, 2024 · 0 comments · May be fixed by #28010
Open
1 task done
Labels
Runtime This issue is a runtime error

Comments

@msw7007
Copy link

msw7007 commented Oct 6, 2024

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1642

Issue Description

When you splash mitochilde on dismembered limb there is a runtime error which prevent mitocholide from rejuvenate a limb and block half of its functional due there is no check for owner of limb is not null

What did you expect to happen?

The limb should call rejuvenate proc without errors

What happened instead?

It's simply fails due execution

Why is this bad/What are the consequences?

It's block an ability of mitocholide to remove bone breakes, internal blidings and critical burns from handling

Steps to reproduce the issue.

Simply spawn limb, splash mitocholide on it, check run time error in:
code/modules/surgery/organs/organ_external.dm
384 - /obj/item/organ/external/rejuvenate()
390 - if(HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS))
there will be no owner, so there will be error

When did the problem start happening?

When zombie mode was implemented

Extra information

To fix it simply add a check.
Maybe something like this:
status = 0
if(is_robotic()) //Robotic organs stay robotic.
status = ORGAN_ROBOT
else if (owner)
if(HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS))
status = ORGAN_DEAD

and something like this futher:
if(!HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool.
open = ORGAN_CLOSED

Relevant log output/runtime error

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Runtime This issue is a runtime error
Projects
Status: Cause Known
2 participants