Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighting.DMI Resprites, Flares, Seclites, Green Lamps, Bulbs, Tubes, Fixtures, Penlights, and Lanterns! #28253

Merged
merged 5 commits into from
Mar 5, 2025
Merged

Lighting.DMI Resprites, Flares, Seclites, Green Lamps, Bulbs, Tubes, Fixtures, Penlights, and Lanterns! #28253

merged 5 commits into from
Mar 5, 2025
+0 −0

Conversation

Alecksohs
Copy link
Contributor

@Alecksohs Alecksohs commented Feb 4, 2025 •
edited
Loading

What Does This PR Do

Resprites several items in lighting.dmi to reduce noisy shading and banding.

Why It's Good For The Game

Looks better.

Images of changes

image
image
image
image
image
image
image
image
image
image

Testing

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Resprites many Lighting objects.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Feb 5, 2025
@Alecksohs Alecksohs changed the title Lighting.DMI Resprites, Flares, Seclites, Green Lamps, Bulbs, Tubes, Fixtures, and Lanterns! Lighting.DMI Resprites, Flares, Seclites, Green Lamps, Bulbs, Tubes, Fixtures, Penlights, and Lanterns! Feb 5, 2025
@Fordoxia
Copy link
Contributor

Fordoxia commented Feb 5, 2025

Is it just me, or does the burned-out flare look thicker than the not-burned-out flare?

@Alecksohs
Copy link
Contributor Author

Likely just pixelscaling.

Contrabang
Contrabang reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Contrabang Contrabang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pen lights arent actually pens, they're flashlights in the shape of pens
imageimage

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 5, 2025
ExusA
ExusA approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ExusA ExusA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites look good to me.

@SynthTwo
Copy link
Contributor

SynthTwo commented Feb 6, 2025

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Feb 6, 2025
@pwbokie
Copy link
Contributor

pwbokie commented Feb 10, 2025

I love the new pen and the new seclite.

The lantern doesn't sit super well with me for a reason that I won't be able to articulate well. I think it has something to do with perspective and something to do with the color scheme.

Overall really visually pleasing stuff.

@github-actions GitHub Actions
Copy link
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Feb 25, 2025
@Alecksohs
Copy link
Contributor Author

Needs a review.

@DGamerL DGamerL requested a review from Contrabang February 25, 2025 03:40
@github-actions github-actions bot removed the Stale This PR has been left inactive and requires an update. label Feb 26, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Mar 5, 2025
@Burzah Burzah added this pull request to the merge queue Mar 5, 2025
Merged via the queue into ParadiseSS13:master with commit 7cd066e Mar 5, 2025
17 checks passed
@Scribble-Sheep
Copy link
Contributor

pen lights arent actually pens, they're flashlights in the shape of pens

They can be written with ingame, tho. Is that unintended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExusA ExusA ExusA approved these changes

@chuga-git chuga-git chuga-git approved these changes

@Burzah Burzah Burzah approved these changes

@Contrabang Contrabang Awaiting requested review from Contrabang

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
Sprite Changes
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Alecksohs @Fordoxia @SynthTwo @pwbokie @Scribble-Sheep @ExusA @Contrabang @chuga-git @Burzah @ParadiseSS13-Bot