Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tiny fans to all emergency shuttles #28309

Closed
wants to merge 1 commit into from

Conversation

Kholdstare2
Copy link
Contributor

@Kholdstare2 Kholdstare2 commented Feb 9, 2025

What Does This PR Do

This PR adds tiny fans to emergency shuttles that don't already have them.

Why It's Good For The Game

With switching over to MILLA, emergency shuttles tend to lose air in seconds if departures is spaced or has other atmospheric issues. Tiny fans fix this by preventing the shuttle from spacing almost immediately if an airlock is opened to a breached area.

Images of changes

Testing

Compiled, looked at all the tiny fans in the airlocks.
Opened airlocks to space, tiny fans kept the shuttle pressurized with nice breathable air.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Added tiny fans to all emergency shuttles.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Feb 9, 2025
@matttheficus
Copy link
Contributor

matttheficus commented Feb 9, 2025

I still really think that making the doors simply crush people and force-bolt when the shuttle takes off would be a lot better than the “magic anti-atmos tile”

I can definitely see a point in placing them on the “emergency entry” side on the Charon for example, as that door is open to space and doesn’t touch the Station.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 9, 2025
@Kholdstare2
Copy link
Contributor Author

I still really think that making the doors simply crush people and force-bolt when the shuttle takes off would be a lot better than the “magic anti-atmos tile”

I can definitely see a point in placing them on the “emergency entry” side on the Charon for example, as that door is open to space and doesn’t touch the Station.

I sadly didn't get any feedback in coding chat when I asked about making this PR. I'm rather indifferent either way. If this is objected to I can close the PR.

@Gatchapod
Copy link
Contributor

If the departures is a hole, it's almost definitely a hijacker's work. I see no reason to code in anti-hijack magic tiles.
If it's not a hijacker's work, engineering should fix the damn place before the shuttle is called. It's their job. "Just run quickly to the shuttle through space" should not be an answer to a destroyed dock.

And yes, I hate tiny fans. The only thing worse than tiny fans are holofans (which, by the way, can be used to address the issue you mentioned).

@FunnyMan3595
Copy link
Contributor

FunnyMan3595 commented Feb 13, 2025

We should be force-closing the doors, not adding magical fans.

@Contrabang
Copy link
Contributor

Design team has unanimously voted against this PR. As such, it will be closed. Reasonings:

  • Close the doors. The only shuttle this is truely an issue on is the pencil shuttle, which is / was moved
  • if God didn't want us to space the shuttle he wouldn't have invented space
  • We should be force-closing the doors, not adding magical fans.
  • The doors should force close and slam on people, bolting shut even with people in them crushing them into pieces. And if the door is bolted open it should automatically unbolt and then do its shut crush.

@Contrabang Contrabang closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Map Edit This PR will modify a map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants