Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCH features cannot be disabled for Super Admins #2874

Closed
acicovic opened this issue Oct 17, 2024 · 1 comment
Closed

PCH features cannot be disabled for Super Admins #2874

acicovic opened this issue Oct 17, 2024 · 1 comment
Milestone

Comments

@acicovic
Copy link
Collaborator

Describe the bug

It has come to our attention that disabling PCH features doesn't work for Super Admins. Whether we uncheck the Administrator User Role, a specific feature or all AI features, Super Admins still see and can use the features that have been disabled in settings.

To Reproduce

  1. Login as a Super Admin.
  2. In the plugin settings under the "Content Helper" tab, disable the "Administrator" User Role, a feature, or all AI features.
  3. Go to the PCH Sidebar.

Instead of the disabled features being invisible and inaccessible, they are shown and are totally operable by Super Admins.

Expected behavior

The disabled features should not be available to Super Admins.

Additional context

Our testing indicates that this bug only affects Super Admins. PCH permissions should be applied correctly to other User Roles.

@acicovic acicovic added this to the Future Milestone milestone Oct 17, 2024
@Parsely Parsely deleted a comment Oct 25, 2024
@acicovic acicovic modified the milestones: Future Milestone, 3.17.0 Oct 30, 2024
@acicovic
Copy link
Collaborator Author

Fixed in #2895, shipping in 3.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@acicovic and others