Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduant constants? #127

Open
jakub791 opened this issue Oct 7, 2022 · 1 comment
Open

Reduant constants? #127

jakub791 opened this issue Oct 7, 2022 · 1 comment

Comments

@jakub791
Copy link

jakub791 commented Oct 7, 2022

There are constants like EXP_LIMIT, NUNBER_EXP_MIN, LAYER_DOWN which I think aren't meant to be changed by people using the library (like some sort of configuration)?
If that's true then it might be better to remove them and just use the values directly in internal code.
@Patashu
Copy link
Owner

Patashu commented Oct 7, 2022

Or like documentation-for-programmers or something.

Could go either way on this one. Never thought about it super hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Patashu @jakub791