Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative Impale DPS for dual wielding combined attacks #8554

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

andyli00
Copy link
Contributor

@andyli00 andyli00 commented Mar 6, 2025

Fixes #8472.

Description of the problem being solved:

Skills that combine both weapon's damage into one hit when dual wielding (Cleave, Dual Strike, Viper Strike, Whirling Blades) would report negative impale DPS under certain conditions like low impale chance or high enemy impale physical damage reduction.
Calculations are now done separately for each hand and then combined instead of averaging the impale base and modifier. This also fixes incorrect calculations in cases where one hand deals significantly more damage than the other (e.g. Dual Strike of Ambidexterity).

Steps taken to verify a working solution:

  • doing the math manually
  • new unit test added for simultaneous attack impale

Link to a build that showcases this PR:

https://poe.ninja/builds/phrecia/character/Expertas%234276/ExpertInTheBin?type=exp&i=5&search=skills%3DDual%2BStrike%2Bof%2BAmbidexterity

Before screenshot:

Negative impale dps:
image
image

After screenshot:

Non-negative impale dps:
image
image

Before/After of same POB with 100% impale chance (to show corrected calculations)

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative Impale DPS on Dual Strike of Ambidexterity
1 participant