Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved remote job search support #105

Open
LilySu opened this issue Sep 18, 2020 · 4 comments
Open

Improved remote job search support #105

LilySu opened this issue Sep 18, 2020 · 4 comments

Comments

@LilySu
Copy link
Contributor

LilySu commented Sep 18, 2020

Description

It would be great to not search by city, as even if the filter can be set for remote, the results returned are still based on city indicated.

Steps to Reproduce

  1. Include '-Indeed' in 'providers:' in the my_settings.yaml
  2. run funnel load -s my_settings.yaml

Expected behavior

Successfully scrape and generate .csv

Actual behavior

Traceback and ValueError if 'province_or_state' or 'city' is not included

Environment

  • Build: 3.0.0
  • Operating system and version: Windows 10
    Desktop Environment and/or Window Manager: Chrome
@LilySu LilySu added the bug label Sep 18, 2020
@LilySu LilySu changed the title Unable to reach Indeed.com due to invalid url Search by "remote" instead of by location on Indeed Sep 18, 2020
@PaulMcInnis
Copy link
Owner

Agreed, I think we can do away with city and perhaps also province in the url entirely if its a Fully remote search.

@PaulMcInnis PaulMcInnis linked a pull request Sep 19, 2020 that will close this issue
15 tasks
@PaulMcInnis PaulMcInnis added this to the 3.0.1 milestone Sep 29, 2020
@PaulMcInnis PaulMcInnis removed a link to a pull request Sep 30, 2020
15 tasks
@PaulMcInnis
Copy link
Owner

per discussion in #106, lets take the approach of allowing city and province/state to be None, with a default of '' in our CSV entries when we write out jobs.

This is valid not only for explicitly remote searches, but also for users who are interested in locating jobs anywhere in a country.

I think it may also make sense to allow for globally-remote searching, but we currently dont' have the appropriate search queries for our providers (which are localised to country). I think it makes sense to leave that feature for when we implement a provider for globally-remote jobs.

@apontejosea
Copy link

For now, probably we can just add the city and make the search radius ridiculously large.

@PaulMcInnis
Copy link
Owner

@Josian good point about search radius. We may also be able to exclude it from the query URL entirely. Need to look into this.

@PaulMcInnis PaulMcInnis modified the milestones: 3.0.1, 3.0.2 Oct 11, 2020
@PaulMcInnis PaulMcInnis changed the title Search by "remote" instead of by location on Indeed Improved remoteness support. Nov 25, 2021
@PaulMcInnis PaulMcInnis changed the title Improved remoteness support. Improved remote job search support Nov 25, 2021
@PaulMcInnis PaulMcInnis modified the milestones: 3.0.3, 4.0 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants