Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect types for uUNIT in UD2x18 and SD1x18 #224

Closed
PaulRBerg opened this issue Apr 9, 2024 · 0 comments · Fixed by #225
Closed

Incorrect types for uUNIT in UD2x18 and SD1x18 #224

PaulRBerg opened this issue Apr 9, 2024 · 0 comments · Fixed by #225
Assignees
@PaulRBerg
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Owner

They should be uint64 and int64, respectively:
@PaulRBerg PaulRBerg added type: refactor Change that neither fixes a bug nor adds a feature. effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Apr 9, 2024
@PaulRBerg PaulRBerg self-assigned this Apr 9, 2024
@PaulRBerg PaulRBerg mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix types for uUNIT PaulRBerg/prb-math
1 participant
@PaulRBerg