Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect requirement spec in UD60x18.log2 #238

Closed
PaulRBerg opened this issue Jun 28, 2024 · 0 comments
Closed

Incorrect requirement spec in UD60x18.log2 #238

PaulRBerg opened this issue Jun 28, 2024 · 0 comments
Assignees
@PaulRBerg
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Owner

Here:

prb-math/src/ud60x18/Math.sol

Line 387 in ebe0395

/// - x must be greater than zero.

It should say:

x must be greater than or equal to UNIT
@PaulRBerg PaulRBerg added effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Jun 28, 2024
@PaulRBerg PaulRBerg self-assigned this Jun 28, 2024
@PaulRBerg PaulRBerg mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg