Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable CSS #1

Open
Metian opened this issue Nov 20, 2024 · 4 comments
Open

Option to disable CSS #1

Metian opened this issue Nov 20, 2024 · 4 comments

Comments

@Metian
Copy link

Metian commented Nov 20, 2024

Hi,

First of all, thank you for this free plugin. It works perfectly (with the Blocksy theme). So far, no issues have been found.

I would like to request a new feature that allows us to disable the plugin's CSS. When using a theme like Blocksy, the switch text gets overwritten and doesn't align with the theme settings, which forces us to override the CSS manually.

Upon reflection, perhaps there could be two options: one to disable only the text-related CSS while retaining the CSS for the switch, and another option to disable all CSS completely, for more advanced developers.

@Paulsky
Copy link
Owner

Paulsky commented Nov 28, 2024

Hello Metian,

Sorry for the late reply! Somehow I didn’t receive a notification.

If you would like this feature, I think it’s best for an option to disable the CSS completely, and not partially because that will be very confusing and I think only advanced developers will use this function anyway. What do you think?

But before we start developing this feature, isn’t it a little strange the theme is overwriting the CSS? Maybe we can fix that? If your theme was not overriding the CSS, would there still be an issue?

@Metian
Copy link
Author

Metian commented Dec 12, 2024

Hi,

No worries, I didn’t receive a notification either.

I think it might be a good idea to provide an option to completely disable the plugin’s CSS, allowing more advanced developers to handle the styling themselves. This could be achieved by implementing a filter in the theme to disable the CSS. Something like add_filter('tax_switch_disable_css', '__return_true'); would suffice to disable the plugin’s frontend CSS entirely.

This approach would likely be sufficient for advanced developers to integrate the plugin into their websites seamlessly.

But before we start developing this feature, isn’t it a little strange the theme is overwriting the CSS? Maybe we can fix that? If your theme was not overriding the CSS, would there still be an issue?

From what I’ve observed, the CSS seems to be added inline in the head. This means it specifically targets parts of the plugin, such as the switch or text, and takes precedence over the theme settings.

For instance, in this example: https://i.gyazo.com/f8eb4a0175c0437e0915ec9c1218af89.png, the header has predefined CSS for text styling and coloring. However, this is overridden by the plugin’s inline CSS.

If we implement a filter (or a similar option) to disable the plugin’s CSS, it would automatically fall back to using the header settings from the theme. This might be a more straightforward solution for addressing the issue.

@Paulsky
Copy link
Owner

Paulsky commented Dec 13, 2024

Hello @Metian ,

Okay, I will put this on the to-do list.

But, in your screenshot, I'm not seeing any overrides. The CSS of the Tax Switch plugin is only targeting it's 'own' elements, no other 'global' elements or other elements out side of the scope. If you want, you can send me the URL so I can have a look.

@Paulsky
Copy link
Owner

Paulsky commented Jan 3, 2025

Hello @Metian , I just installed and activated the Blocksy theme. The CSS is not overriden in anyway at my end. Could you please share the URL (or via my website's contactform if you want to keep it private)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants