-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove obsolete scripts/qsub_build.sh #3133
Comments
I'm not sure what qsub_build.sh was for (I can't find anything else calling it or anything in the documentation), but the current script for installing dependencies is docker/depends/pecan.depends.R |
This issue is stale because it has been open 365 days with no activity. |
I’d like to work on this issue, is anyone currently working on it? |
@AdarshSahani003 Go for it! I think the correct resolution is a PR that simply deletes qsub_build.sh and then states in the PR description how you confirmed that it's not used anywhere else in the repo. |
@infotroph hey !! since there is no updates on this i thought to raise a PR that fixes this particular issue , kindly review it and suggest any changes if needed , i will also attach a detailed description in the PR about why the script is obsolete . Thank you !! |
Remove obsolete qsub_build.sh script
Bug Description
qsub_build.sh uses install.dependencies.R which is no longer there, It should use install_pecan.sh instead as I thought
https://github.com/PecanProject/pecan/blob/develop/scripts/qsub_build.sh
To Reproduce
Steps to reproduce the behaviour:
The text was updated successfully, but these errors were encountered: