You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently the workflow goes like, on approval of a PR, we go on to put the PR in the merge group where workflow will get triggered and then when the PR will get merged, a second workflow will get triggered.
Proposed Solution
Describe the solution you'd like
I was proposing that we skip the Renderbook and CI tests on it's merge with the develop branch as the tests would already have been passed in the merge group.
No need to update the Docker workflow as it will publish the latest images on DockerHub once we merge the PR onto the develop branch.
But the workflow for CI and Renderbook might be skipped as for CI we do not publish it anywhere and for Renderbook, it gets published to github in the merge queue itself (Example).
For CI and Renderbook workflow, I am proposing:
on:
push:
branches:
- master
Instead of:
on:
push:
branches:
- master
- develop
Additional Context
Shall I make a Pull Request updating these changes?
The text was updated successfully, but these errors were encountered:
Description
Is your feature request related to a problem? Please describe.
Currently the workflow goes like, on approval of a PR, we go on to put the PR in the merge group where workflow will get triggered and then when the PR will get merged, a second workflow will get triggered.
Proposed Solution
Describe the solution you'd like
I was proposing that we skip the Renderbook and CI tests on it's merge with the develop branch as the tests would already have been passed in the merge group.
No need to update the Docker workflow as it will publish the latest images on DockerHub once we merge the PR onto the develop branch.
But the workflow for CI and Renderbook might be skipped as for CI we do not publish it anywhere and for Renderbook, it gets published to github in the merge queue itself (Example).
For CI and Renderbook workflow, I am proposing:
Instead of:
Additional Context
Shall I make a Pull Request updating these changes?
The text was updated successfully, but these errors were encountered: