Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clickhouse] Add validation during mirror creation to check if destination tables exist and if they do, are valid to sync to #2019

Open
5 of 6 tasks
heavycrystal opened this issue Aug 29, 2024 · 0 comments
Open
5 of 6 tasks

[clickhouse] Add validation during mirror creation to check if destination tables exist and if they do, are valid to sync to #2019

heavycrystal opened this issue Aug 29, 2024 · 0 comments
Assignees
@heavycrystal

Comments

@heavycrystal
Copy link
Contributor

heavycrystal commented Aug 29, 2024 •
edited
Loading

Cases:

  • Check if table doesn't exist, if so proceed.
    Table exists:
  • Columns should match what is in Postgres incl. column exclusion.
  • Presence of metadata columns.
  • Types should match for columns.
  • Table should be empty.
  • Table should be ReplacingMergeTree
@heavycrystal heavycrystal self-assigned this Aug 29, 2024
@heavycrystal heavycrystal mentioned this issue Aug 30, 2024
Merged
heavycrystal added a commit that referenced this issue Sep 4, 2024
@heavycrystal
[clickhouse] validate certain aspects of existing destination tables (#…
ee00aad 
…2026)

Partially addresses #2019 

Tests column name equality taking exclusion into account, PeerDB
columns, engine and emptiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heavycrystal heavycrystal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heavycrystal