Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Champion/Warrior Medals? #49

Open
jsj1027 opened this issue Sep 27, 2024 · 4 comments
Open

Support for Champion/Warrior Medals? #49

jsj1027 opened this issue Sep 27, 2024 · 4 comments

Comments

@jsj1027
Copy link

jsj1027 commented Sep 27, 2024

I know these plugins have this built in, but it would be nice to have it all in 1 UI.

@Catalistique
Copy link

I made exactly that a few weeks ago so, seeing this, I decided to publicly release it on Openplanet as Ultimate Medal++

@zai-tm
Copy link
Contributor

zai-tm commented Oct 10, 2024

I made exactly that a few weeks ago so, seeing this, I decided to publicly release it on Openplanet as Ultimate Medal++

Why didn't you just make this a PR for this plugin? It doesn't need to be in it's own plugin.

@XertroV
Copy link

XertroV commented Oct 10, 2024

#50 fixes this if it ever gets merged

@Catalistique
Copy link

Why didn't you just make this a PR for this plugin? It doesn't need to be in it's own plugin.

Yeah, you're not the only one who told me this and honestly you're right. However, my code was not the greatest and I had never contributed to an open-source project.

Since XertroV and Nsgr did it too, I don't know if it fixes anything, but I rewrote the plugin and also made a pull request. Sorry again to everyone, made a lapse of judgement. Btw, if there's any way to unrelease a plugin, please tell me and I'll do it as soon as the merge is made.

The pull request I made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants