Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relicense photon-serde as MIT #1704

Closed
gerth2 opened this issue Jan 11, 2025 · 4 comments · Fixed by #1709
Closed

Relicense photon-serde as MIT #1704

gerth2 opened this issue Jan 11, 2025 · 4 comments · Fixed by #1709
Labels
Pending - Needs More Info Development is currently stalled, waiting on more info from folks involved. question Further information is requested

Comments

@gerth2
Copy link
Contributor

gerth2 commented Jan 11, 2025

serde (currently GPLv3) is generating source files which are distributed with photon-lib (intended to be MIT). This is technically incompatible, as it implies photon-lib is actually GPLv3, not MIT as intended.

While we don't expect any individual FRC team to hit the threshold of distributing their software that uses photon-lib, we'd like to be technically correct anyway.

Change serde's licensing to be MIT (new license.txt file, new headers) to keep photon-lib entirely MIT.

As of commit e40c8fbca08e8397e00e35f72809ac69d752ad57 on main, contributors are:

 git shortlog -n -s -- photon-serde
     4  Lucien Morey
     3  Matt
     1  Jade

@LucienMorey @mcm001 @spacey-sooty before this proceeds, can you comment below with an explicit "agree" below that code you wrote will be relicensed from GPLv3 to MIT ?

@gerth2 gerth2 added enhancement New feature or request question Further information is requested Pending - Needs More Info Development is currently stalled, waiting on more info from folks involved. and removed enhancement New feature or request labels Jan 11, 2025
@mcm001
Copy link
Contributor

mcm001 commented Jan 11, 2025

Yes, I'm happy to release my contributions to photon-serde and the autocode it generates under MIT.

I think we will still need to relicense photon-targeting right?

@spacey-sooty
Copy link
Member

I am also happy with any of my contributions to photon-serde to be MIT.

@LucienMorey
Copy link
Contributor

I agree

@auscompgeek
Copy link
Contributor

I can split out the photon-serde change from #1702 if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending - Needs More Info Development is currently stalled, waiting on more info from folks involved. question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants