-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC1 / RC.1 version naming issue #1733
Comments
Waiting for PhotonVision/photonvision#1733 to resolve to build.
Re ran CI |
The vendordep JSON file that comes in through the WPILib "Manage Vendor Libraries" tool is now of the While this allows GitHub CI to pass, the VSCode build still crashes on my local machine with the error:
If, however, I add the
|
The url you sent, |
I am having the unusual situation of VSCode not being able to reach the file at This is even after restarting VSCode and running Since the Photon Vision problem has been resolved, I will close this issue. Thanks for cleaning up the |
Describe the bug
There seems to be inconsistency in naming of PhotonLib target files between "
rc1
" and "rc.1
" with the former associated with thelinuxx86_64
images and the latter with thelinuxathena
,osxuniversal
, andwindowsx86
images (c.f. https://maven.photonvision.org/#/releases/org/photonvision/photontargeting-cpp/). This inconsistency makes it impossible to make robot code based on PhotonVision's 2025 RC1 release build both for the robot and in GitHub's CI environment.To Reproduce
Follow either path:
rc1
variant) to try to build a robot project. This will crash in VSCode with the error:photonlib.json
file passed through the WPILib "Manage Vendor Libraries" tool, using the URL in the Photon Vision docs (therc.1
variant). While this pathway builds properly in VSCode, it causes a crash in GitHub's CI tool with the error:Platform:
v2025.1.1-rc1
/v2025.1.1-rc.1
The text was updated successfully, but these errors were encountered: