Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow centralized configuration and document it #4

Open
bnjbvr opened this issue Apr 8, 2018 · 3 comments
Open

Allow centralized configuration and document it #4

bnjbvr opened this issue Apr 8, 2018 · 3 comments

Comments

@bnjbvr
Copy link

bnjbvr commented Apr 8, 2018

It'd be great if we could just have a single configuration file or a single directory containing configuration files with all the example configuration files. I think that if the projects gets away from Docker, it does make sense to stop using env variables as the unique way to define configuration variables, and it would make it simpler to use this project if we had a centralized place with all the possible configuration values.

@bnjbvr bnjbvr changed the title Allow centralized documentation Allow centralized configuration Apr 8, 2018
@bnjbvr bnjbvr changed the title Allow centralized configuration Allow centralized configuration and document it Apr 8, 2018
@Phyks
Copy link
Owner

Phyks commented Apr 8, 2018

Sure, this is definitely something desirable. Docker seems quite convenient, especially the Docker compose stuff, I simply don't use it.

The setup/run scripts are more oriented towards demo/dev at the moment.

Still, it's interesting to keep in mind that micro services can run on different servers. My current setup is:

  • viewer and indexer on my main web server, publicly accessible
  • crawlers on a raspberry pi at home, accessible only from my LAN, as it handles my passwords

@Phyks
Copy link
Owner

Phyks commented Apr 8, 2018

Another useful feature on this might be to embed doc of each micro service inside the micro service itself, based on ideas from selfapi/swagger and similar to what janitor does.

@Phyks
Copy link
Owner

Phyks commented Apr 9, 2018

By the way, there are two types of config and environment variables:

  • The local ones, to configure the microservice itself (host, port, misc options such as imap credentials).
  • The global ones, to connect the microservices together (INDEXER_URL etc).

In an ideal world, I think the routing should be handled by something such as infotuyo, hence the global configuration would not exist. But local configuration should remain local for each microservice, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants