diff --git a/src/dbt_score/dbt_utils.py b/src/dbt_score/dbt_utils.py index fa89938..b2b00f5 100644 --- a/src/dbt_score/dbt_utils.py +++ b/src/dbt_score/dbt_utils.py @@ -9,7 +9,7 @@ # Conditionally import dbt objects. try: DBT_INSTALLED = True - from dbt.cli.main import dbtRunner, dbtRunnerResult # type: ignore + from dbt.cli.main import dbtRunner, dbtRunnerResult except ImportError: DBT_INSTALLED = False diff --git a/src/dbt_score/rules/generic.py b/src/dbt_score/rules/generic.py index 8b1cf78..8138a4b 100644 --- a/src/dbt_score/rules/generic.py +++ b/src/dbt_score/rules/generic.py @@ -63,8 +63,8 @@ def has_uniqueness_test(model: Model) -> RuleViolation | None: pk_columns = None # At column level? for column in model.columns: - for constraint in column.constraints: - if constraint.type == "primary_key": + for column_constraint in column.constraints: + if column_constraint.type == "primary_key": pk_columns = [column.name] break else: @@ -72,9 +72,9 @@ def has_uniqueness_test(model: Model) -> RuleViolation | None: break # Or at table level? if pk_columns is None: - for constraint in model.constraints: - if constraint["type"] == "primary_key": - pk_columns = constraint["columns"] + for model_constraint in model.constraints: + if model_constraint["type"] == "primary_key": + pk_columns = model_constraint["columns"] break if pk_columns is None: # No PK, no need for uniqueness test @@ -90,7 +90,7 @@ def has_uniqueness_test(model: Model) -> RuleViolation | None: for data_test in model.tests: if data_test.type == "unique_combination_of_columns": - if set(data_test.kwargs.get("combination_of_columns")) == set(pk_columns): + if set(data_test.kwargs.get("combination_of_columns")) == set(pk_columns): # type: ignore return None return RuleViolation("There is no uniqueness test defined and matching the PK.")