Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change entities naming in v2.0.0 leads to incompatibility with MeteoalarmCard #22

Closed
nepozs opened this issue Jul 15, 2023 · 2 comments
Closed

Comments

@nepozs
Copy link
Contributor

nepozs commented Jul 15, 2023

MrBartusek/MeteoalarmCard#201
as you can see - the weather condition is selected by the name of the entity
https://github.com/MrBartusek/MeteoalarmCard/blob/master/src/integrations/burze_dzis_net.ts
so if these names are not in English, they won't work properly.
If these names will always be Polish, it will be easy to fix.

@PiotrMachowski
So maybe this change needs your declaration if will it be persistent change.

There is also secondary problem - I don't understand idea of doubling entities:
all of
binary_sensor.burze_dzis_net_ostrzezenie_aktywne_xxx
are identical to
binary_sensor.burze_dzis_net_ostrzezenie_xxx

@PiotrMachowski
Copy link
Owner

PiotrMachowski commented Jul 16, 2023

The problem is that now it's possible to change entity IDs for entities generated by this integration. I have a solution for that (I use it in my vacuum map card), I'll check if I'll be able to apply it in Meteoalarm card.


"Aktywne" entities mean that there is a warning and it is active at this moment (warnings have start and end times and they can be published e.g. a day before)
Normal entities are "on" whenever there is a warning, without checking the time.

@PiotrMachowski
Copy link
Owner

I'll close this issue as it should be handled on the card side

@PiotrMachowski PiotrMachowski closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants