-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this library maintained? #78
Comments
Hi @JayWalker512. In the past I would go through the PRs in chunks every few months whenever I found time. Unfortunately I have been quite busy with my life the last period so didn't have the chance to put more time into this. I understand your concern which is also why I built the library in the first place. However since I don't use C anymore on a daily basis and due to having to deal with other things, I can't tell if I will be able to go through the PRs in the short-term at least. I'm happy to give access to people to maintain the project, assuming they share the same vision for keeping the solution elegant and minimal. Cheers |
I volunteer to help merging some of the PRs, if you offer still stands. In fact, I will send at least one of my own, just for docs, because I see the code changes I wanted to make have already been included in other PRs. |
@gonzus yes sure, that would be great! Just let me update the CI, since I noticed it's broken, and I will add you. |
Hey, got the invite, already approved two PRs. I didn't want to approve a pending PR of my own (#91), thought it would be bad form -- if you are OK with that, I can approve it. |
Hi @Pithikos, As we rely heavily on your lib (thanks for your work!) for FrankenPHP, I would also be happy to get the commit right to merge the fixes we need :) Cheers, |
I merged a few things and with Github Actions now (thanks @dunglas) things should be easier. Feel free to nudge me for anything to improve collaboration. Have a good 2024 🍰 |
Haha! That latest merge resolved my problem, on my workload the threads got stuck without doing any work sometimes. I ended up rewriting thpool.c and went back here to see how I could contribute. No need anymore, nice work. |
There are numerous years-old pull requests, the library appears to have been left to rot. That would be a shame because I haven't been able to find any other good pure-C threadpool libraries.
The text was updated successfully, but these errors were encountered: