Modernize TBB CMake setup by exclusively relying on CMake namespace targets #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argets Using CMake namespace target is the modern approach, it forward definitions, include directories and link libraries transitively to consumers. And one is already setup by the `FindTBB.cmake` module. As the main CMakeLists.txt already requires CMake 3.14 this should already be available to all CMake clients. Additionally try to resolve TBB Config package before trying the module one.
7 tasks
|
Filed as internal issue #USD-9934 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
theblackunknown
force-pushed
the
cmake-find-tbb
branch
from
6048214 to
d17762c
Compare
theblackunknown
force-pushed
the
cmake-find-tbb
branch
from
d17762c to
a1075a6
Compare
|
Hey @jesschimein I have reproduced yesterday issues locally when building without using oneTBB and I have pushed a new fix to accommodate those. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @jesschimein , I am not sure to understand whether the last azure pipeline run for windows is a genuine error or not. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Yeah, some of the timeouts are a little fickle, and we usually rerun to check. Looks like Windows successfully built this time! 🙌🏻 |
|
Hi @jesschimein there is now a large list of conflicts, if I resolve them is there a good chance to integrate my change for the next release ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Using CMake namespace target is the modern approach, it forwards definitions, include directories and link libraries transitively to consumers.
One
TBB::tbbis already produced by theFindTBB.cmakemodule.As the main CMakeLists.txt already requires CMake 3.14 this should already be available to all CMake clients.
Additionally try to resolve TBB Config package before trying the module one.
Miscellaneous associated cleanups are made with remaining commits.