fix(availability): PPT-1629 return 404 when tenant not found

[naqvis]

No description provided.

[stakach]

I think we should just add a before_filter that calls this function:

staff-api/src/controllers/utilities/multi_tenant.cr

Lines 33 to 38 in 5b325ad

	def current_tenant : Tenant
	determine_tenant_from_domain unless @tenant
	the_tenant = @tenant
	raise Error::NotImplemented.new("domain does not have a tenant configured") unless the_tenant
	the_tenant
	end

Then this would respond appropriately for every route in the controller

example before_filter:

staff-api/src/controllers/bookings.cr

Lines 36 to 47 in 6a24c92

	@[AC::Route::Filter(:before_action, only: [:index, :add_attendee, :booked])]
	private def set_tenant_from_domain
	if auth_token_present?
	check_jwt_scope
	determine_tenant_from_domain
	else
	domain = request.hostname.as?(String)
	raise Error::BadRequest.new("missing domain header") unless domain
	@tenant = Tenant.find_by?(domain: domain)
	raise Error::NotFound.new("could not find tenant with domain: #{domain}") unless tenant
	end
	end

[naqvis]

confused here on the approach you suggested and approach ode is making decision on . code is returning 404 only if matching calendars are empty, but your suggestion is to retrieve tenant from PG.

Question would be how does this PG stored tenant relates to Office Calendars returned response being empty?

[stakach]

confused here on the approach you suggested and approach ode is making decision on . code is returning 404 only if matching calendars are empty, but your suggestion is to retrieve tenant from PG.

Question would be how does this PG stored tenant relates to Office Calendars returned response being empty?

I was confused by the title of this issue:
return 404 when tenant not found
That should be
return 404 when no matching calendars found

I think there are two issues being conflated

1. if a tenant isn't configured then we should be raising something like a Not Implemented - a 501 maybe? We should consult with @MrYuion to ensure this wouldn't disrupt the frontend
2. we should raise a 204 No Content maybe to indicate that no matching calendars were found with a valid empty response object?

As no candidate calendars is a valid thing that can happen but we want to differentiate that from graph api errors etc so a 404 is not correct and probably would confuse things further
@jeremyw24 do you agree?

[stakach]

LGTM