Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Enhance Build Process Feedback with Loading Animation #1117

Open
4 tasks done
actopas opened this issue Oct 23, 2024 · 0 comments
Open
4 tasks done

[RFC] Enhance Build Process Feedback with Loading Animation #1117

actopas opened this issue Oct 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@actopas
Copy link
Contributor

actopas commented Oct 23, 2024

How do you envision this feature/change to look/work like?

During the development of my plugin card, for some reason, the build process once exceeded 40,000ms. When saving the code, there is no specific perception of whether everything is in the queue, or the prompt is being built. The most annoying thing is that after multiple hot reloads, I look at the terminal page 🟢 DONE | Extension re-packaged in, and it is difficult to tell whether the build is now completed. So I hope to add a loading information prompt at the beginning of the build/hot reload, and no longer display loading when the loading is completed or failed, to improve the perception of the build and hot reload.
image

What is the purpose of this change/feature? Why?

  • Provide a better user experience by letting users know that a build is in progress;

  • clearly indicate the start and end of a build;

  • and stop the loading animation in time when a build fails to avoid user confusion;

(OPTIONAL) Example implementations

Specifically, the functional implementation:
Display the loading animation when the build/hot reload starts in the terminal
Stop and remove the animation when the build succeeds or fails
Use the startLoading() and stopLoading() functions to control the loading animation
test23

(OPTIONAL) Contribution

  • I would like to contribute to this RFC via a PR

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@actopas actopas added the enhancement New feature or request label Oct 23, 2024
@actopas actopas changed the title [RFC] [RFC] Enhance Build Process Feedback with Loading Animation Oct 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
* feat: add build loading awareness in the terminal

- Import loading awareness animation for build process
- Start loading animation when build and rebuild starts
- Stop loading animation when build succeeds or fails

* refactor: improve loading animation code structure

- Move state management to a single state object
- Extract LOADING_TEXT to constants
- Add consistent bracket style

---------

Co-authored-by: L <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant