Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for modifier key combinations #124

Closed
1 task done
FlyMeToTheMoonAndLetMePlayAmongTheStars opened this issue Feb 6, 2023 · 4 comments
Closed
1 task done
Labels
enhancement New feature or request

Comments

@FlyMeToTheMoonAndLetMePlayAmongTheStars
Copy link
Contributor

Is your feature request related to a problem?

You can only do so much with the standard single key values that can be mappped to a single point on screen.

Describe the solution you'd like

Support for modifier key combinations such as ctrl ⌃ + <key>, this would allow an extra dimension of functionality to be added and account for certain in-game UI elements that would otherwise have to be mapped to an inconvenient key value or not mapped at all.

For example, everyone's fav game: Genshin Impact

There is currently no convenient way to activate the button that switches to a character AND uses their element burst. You can try releasing the cursor to do it but this is unrealistic given how you need to react fast to changing conditions in combat. Or you can try to map it to another key but there's no convenient option within reach.

With my proposed solution, this problem can be solved since users will be able to map something like ctrl + 1, 2, or 3 to a button that presses on the off field char's elemental burst to switch them in. Another benefit is you could map some other common UI elements to ctrl, such as ctrl + E for the events page, ctrl + B for BP, and so on-without having to deal with those pesky F keys that nobody wants to press on a Mac.

Anything else?

Could look something like this (combined with on-screen keymap hint UI concept - #74)

image

Issue Language

  • Yes my issue is written in English
@XuYicong
Copy link
Member

It's better to map option than control or command, since that would be semantically more accurate and the latter two are often used by the operating system. This should be carefully implemented so that it does not cause keymap format incompatibility.

@FlyMeToTheMoonAndLetMePlayAmongTheStars
Copy link
Contributor Author

I did consider mapping option but I thought it might conflict with how the key currently works as the button for toggling keymapping. In the PC version of Genshin, it is indeed option/left alt + number to switch to tag in a char and use their burst. If you do go with option would there need to be changes to how users can toggle keymapping? Right now it's a convenient single key press, but if you were to bind it as a modifier key, would you still be able to keep this experience? Or would you have to change the behavior to press and hold to toggle keymapping to avoid conflicts with a single press of option + another key?

@XuYicong
Copy link
Member

XuYicong commented Feb 13, 2023

In the PC version of Genshin, it is indeed option/left alt + number to switch to tag in a char and use their burst.

Note that while doing this, Genshin still have alt key for releasing cursor. It's possible to just check if the user is pressing other keys while holding option, so as to decide which action to perform when the user releases option key.

@XuYicong XuYicong transferred this issue from PlayCover/PlayCover Oct 2, 2023
@XuYicong XuYicong added the keymap format change This issue or pull request introduces incompatible keymapping file format changes label Oct 2, 2023
@XuYicong XuYicong removed the keymap format change This issue or pull request introduces incompatible keymapping file format changes label Jun 15, 2024
@XuYicong
Copy link
Member

XuYicong commented Jul 3, 2024

Available since PlayCover 3.0.0

@XuYicong XuYicong closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants