Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemsAdder and nChat Bug #3197

Open
5 tasks done
SrMonsterYT opened this issue Dec 7, 2023 · 4 comments
Open
5 tasks done

ItemsAdder and nChat Bug #3197

SrMonsterYT opened this issue Dec 7, 2023 · 4 comments
Labels
type: bug Something isn't working type: other plugin bug This is another plugin bug.

Comments

@SrMonsterYT
Copy link

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

mauriciooficial

What happened?

video: https://www.youtube.com/watch?v=wQKjWYukA5Y

has an itemadder conflict with nchat, when typing in chat [item]
when I type [item] it shows the item I have in my inventory

Steps to reproduce the issue

video: https://www.youtube.com/watch?v=wQKjWYukA5Y

Server version

Pufferfish version git-Pufferfish-27 (MC: 1.20.1)

ItemsAdder Version

ItemsAdder_3.6.2c

ProtocolLib Version

5.1.1-SNAPSHOT-673

LoneLibs Version

LoneLibs 1.0.31

FULL server log

no error

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

@SrMonsterYT SrMonsterYT added the type: bug Something isn't working label Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

Hello,
your report will be looked into as soon as possible.
Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Jan 3, 2024

It's related to this issue, I am waiting the Adventure API team to answer: KyoriPowered/adventure#1025

It's basically caused by the fact that for some reason nChat is sending legacy hover raw messages to 1.16+ clients (it should not do that btw) and Adventure can't convert them for some reason.

@LoneDev6 LoneDev6 added the type: other plugin bug This is another plugin bug. label Jan 3, 2024
@SrMonsterYT
Copy link
Author

@LoneDev6 i updated itemadder to version 3.6.3-beta-7 and it bugged out again, do i have to stay on that version until it's fixed?

in version 3.6.2c.jar just do this and [item] works:

font_images:
replace-in-customitems-name-and-lore: true
chat:
enabled: false
add-hover-suggestion: false
tab-autocompletion_1_19_1_plus: true

@LoneDev6
Copy link
Collaborator

It's basically caused by the fact that for some reason nChat is sending legacy hover raw messages to 1.16+ clients (it should not do that btw) and Adventure can't convert them for some reason.

This is is basically a bug of nChat since they are using legacy hover event JSON components.
Ask its developer to migrate to the modern version.
I can't do anything against that.
The only other solution is to wait the Adventure team to fix that in their API, but I doubt as legacy components are unsupported and should never be used anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: other plugin bug This is another plugin bug.
Projects
Status: Stalled
Development

No branches or pull requests

2 participants