-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
>1.16 block properties are not always extracted correctly #23
Comments
Versions prior to 1.16 also do a similar thing (for instance, MCP names, Burger/burger/toppings/blocks.py Lines 360 to 370 in fd0f3a5
I'm not sure why that wouldn't be working now. |
Whoops, I didn't notice that there was similar code in <=1.15, looks like they just made an abstract class and moved most of stuff previously done in I'm not sure why wouldn't it work, signatures should look pretty similar, but again, I can only guess based on Burger's output and MCP-mapped Minecraft code :( |
Since 1.16 some blocks are just inheriting things like hardness and blast resistance from parent blocks, some examples are:
brick_stairs ... AbstractBlock.Properties.from(BRICKS)
quartz_stairs ... AbstractBlock.Properties.from(QUARTZ_BLOCK)
cobblestone_wall ... AbstractBlock.Properties.from(COBBLESTONE)
granite_slab ... AbstractBlock.Properties.from(GRANITE)
gilded_blackstone ... AbstractBlock.Properties.from(BLACKSTONE)
Complete list of affected properties:
material, hardness, resistance, blocksMovement, ticksRandomly, lightLevel, blockColors, soundType, slipperiness, speedFactor, variableOpacity, isSolid, isAir, requiresTool
All these blocks lose inherited properties in burger output, I'd love to fix it myself, but I'm not experienced enough to make burger follow such method calls and extract parents properties :(
Thanks for the great tools, Pokechu and contributors!
The text was updated successfully, but these errors were encountered: